Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SumState-Alerting #3

Merged
merged 7 commits into from
Jan 12, 2024
Merged

Conversation

da-Kai
Copy link
Contributor

@da-Kai da-Kai commented Sep 14, 2023

Description:

Notify specific users of the persistent presence of a negative sumState.

This pull request is linked to the following:
OpenEMS/openems#2260

@da-Kai da-Kai marked this pull request as ready for review January 10, 2024 11:05
openems/controllers/alerting.py Outdated Show resolved Hide resolved
openems/controllers/alerting.py Outdated Show resolved Hide resolved
openems/mail/openems/alerting_sum_state.xml Outdated Show resolved Hide resolved
openems/mail/openems/alerting_sum_state.xml Outdated Show resolved Hide resolved
openems/controllers/alerting.py Outdated Show resolved Hide resolved
openems/controllers/alerting.py Outdated Show resolved Hide resolved
openems/models/device.py Outdated Show resolved Hide resolved
Copy link

@michaelgrill michaelgrill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙂👍

@michaelgrill
Copy link

@sfeilmeier FYI finished with my review

Copy link
Contributor

@sfeilmeier sfeilmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok from my side!

Please do an internal PR as well, because Odoo-OpenEMS-Addon and our internal module are not fully in sync yet, unfortunately.

@sfeilmeier sfeilmeier merged commit 86e0678 into OpenEMS:16.0 Jan 12, 2024
sfeilmeier added a commit to OpenEMS/openems that referenced this pull request Feb 20, 2024
…!) (#2260)

Notify specific users of the persistent presence of a negative sumState.

- react and send mail on sumState
- Improved data structure for growing alerting requirements and settings
- Unit-Tests
- UI settings

Requires updated Odoo addon: OpenEMS/odoo-openems#3

Co-authored-by: Kai Jeschek <[email protected]>
Co-authored-by: Stefan Feilmeier <[email protected]>
fanass-dev pushed a commit to fanass-dev/openems that referenced this pull request May 6, 2024
…!) (OpenEMS#2260)

Notify specific users of the persistent presence of a negative sumState.

- react and send mail on sumState
- Improved data structure for growing alerting requirements and settings
- Unit-Tests
- UI settings

Requires updated Odoo addon: OpenEMS/odoo-openems#3

Co-authored-by: Kai Jeschek <[email protected]>
Co-authored-by: Stefan Feilmeier <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants